Sync analysis_options.yaml with flutter/flutter#34986
Conversation
goderbauer
force-pushed
the
syncAnalysisOptions
branch
from
229c1f8 to
416ca7b
Compare
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
Thanks! So much better.
|
@yjbanov Can you scan through the changes this required in |
goderbauer
force-pushed
the
syncAnalysisOptions
branch
from
ac7e503 to
9bbdb8c
Compare
| missing_return: warning | ||
| native_function_body_in_non_sdk_code: ignore | ||
| # allow having TODOs in the code | ||
| native_function_body_in_non_sdk_code: ignore # DIFFERENT FROM FLUTTER/FLUTTER |
There was a problem hiding this comment.
We shouldn't need this anymore now that we're on FfiNative.
There was a problem hiding this comment.
Mind if I remove this in a follow-up?
There was a problem hiding this comment.
Trying to turn this on in #35015 to see what (if anything) breaks.
| # Turned off until null-safe rollout is complete. | ||
| unnecessary_null_comparison: ignore | ||
| # TODO(goderbauer): remove when https://github.com/dart-lang/sdk/issues/49563 is fixed. | ||
| ffi_native_unexpected_number_of_parameters: ignore |
There was a problem hiding this comment.
This is different from flutter right?
There was a problem hiding this comment.
Yeah, will leave a comment on it.
| - avoid_return_types_on_setters | ||
| # - avoid_returning_null # there are plenty of valid reasons to return null | ||
| # - avoid_returning_null_for_future # not yet tested | ||
| # - avoid_returning_null # still violated by some pre-nnbd code that we haven't yet migrated |
There was a problem hiding this comment.
What code have we not migrated? Can we make sure an issue is filed for this?
There was a problem hiding this comment.
This is just syncing over from flutter/flutter and that's what we have there. Happy to take another look at this particular lint in a follow-up.
There was a problem hiding this comment.
SGTM, we should be fully NNBD in this repo (except for flutter_frontend_server and a couple stray files in fuchsia embedding.
There was a problem hiding this comment.
Trying to turn this on in #35015 to see what (if anything) breaks.
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
This is overall an improvement, feel free to land and file issues/follow up on my comments subsequently to avoid merge conflicts with bots
goderbauer
added
the
autosubmit
5 participants
No description provided.